Skip to content

s/getRootNode/ownerDocument #28412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickhanlonii merged 5 commits into from
Feb 22, 2024
Merged

s/getRootNode/ownerDocument #28412

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64b2210
s/getRootNode/ownerDocument
rickhanlonii Feb 21, 2024
cdf0c6b
use document
rickhanlonii Feb 22, 2024
fab2702
unblocked may not === document
rickhanlonii Feb 22, 2024
a7e3cdf
Compress error message
rickhanlonii Feb 22, 2024
f4e3c83
Fix other strings
rickhanlonii Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-dom-bindings/src/events/ReactDOMEventReplaying.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ export function retryIfBlockedOn(

if (enableFormActions) {
// Check the document if there are any queued form actions.
const root = unblocked.getRootNode();
Comment thread
rickhanlonii marked this conversation as resolved.
const root = unblocked.ownerDocument;
const formReplayingQueue: void | FormReplayingQueue = (root: any)
.$$reactFormReplay;
if (formReplayingQueue != null) {
Expand Down
2 changes: 1 addition & 1 deletion ...m-bindings/src/server/fizz-instruction-set/ReactDOMFizzInstructionSetInlineCodeStrings.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...es/react-dom-bindings/src/server/fizz-instruction-set/ReactDOMFizzInstructionSetShared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export function listenToFormSubmissionsForReplaying() {
// where we preserve sequencing and where we'll pick it up from during hydration.
// In practice, this is just the same as document but we might support shadow trees
// in the future.
Comment thread
rickhanlonii marked this conversation as resolved.
Outdated
const root = form.getRootNode();
const root = form.ownerDocument;
(root['$$reactFormReplay'] = root['$$reactFormReplay'] || []).push(
form,
submitter,
Expand Down