Re-enable prettier for compiler/

[poteto]

Stack from ghstack (oldest at bottom):

• [compiler:codegen] Wrap non-ascii characters in JsxExpressionContainer #29997
• -> Re-enable prettier for compiler/ #29993

Now that the compiler directory has its own prettier config, we can
remove the prettierignore entry for compiler/ so it still runs in your
editor if you open the root directory

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2024 4:03pm

[react-sizebot]

Comparing: b15c849...a78be41

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.js	=	6.66 kB	6.66 kB	+0.05%	1.82 kB	1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	=	497.93 kB	497.93 kB	=	89.26 kB	89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js	=	6.67 kB	6.67 kB	+0.05%	1.83 kB	1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	=	502.75 kB	502.75 kB	=	89.96 kB	89.96 kB
facebook-www/ReactDOM-prod.classic.js	=	597.17 kB	597.17 kB	=	105.33 kB	105.33 kB
facebook-www/ReactDOM-prod.modern.js	=	571.52 kB	571.52 kB	=	101.27 kB	101.27 kB
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Generated by 🚫 dangerJS against a78be41

[kassens]

Please also update CI so this is checked, I think all that's needed is this glob:
https://github.com/facebook/react/blob/main/scripts/prettier/index.js#L54

[poteto]

Please also update CI so this is checked, I think all that's needed is this glob: https://github.com/facebook/react/blob/main/scripts/prettier/index.js#L54

I think you may have looked at the older commit, I already pushed those changes

[kassens]

The linked glob '**/*.js' doesn't match *.ts and *.tsx files, right? Does yarn prettier-all format ts files?

[kassens]

see above

[poteto]

@kassens I think there's some misunderstanding. the compiler has its own prettier config if you look at the compiler directory. This particular top level script doesn't need to run on the compiler directory as a result and so the current setup to only run on .js files and ignore compiler is correct. Keep in mind this script only runs in CI.

But leaving the compiler entry in .prettierignore is disabling prettier itself in the editor if you open the root directory instead of just the compiler. Additionally it would try to run prettier on some .js files in compiler. So essentially the right thing to do is to remove the compiler from .prettierignore (allowing the editor to invoke prettier) and continue skipping it in the prettier script which only runs in CI.

[kassens]

I see, would be nice to integrate into the main prettier CI now that Forget is merged.