[compiler] Fix dropped ref with spread props in InlineJsxTransform#31726
Merged
jackpope merged 1 commit intofacebook:mainfrom Dec 10, 2024
Merged
[compiler] Fix dropped ref with spread props in InlineJsxTransform#31726jackpope merged 1 commit intofacebook:mainfrom
jackpope merged 1 commit intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bf75f8f to
40cdf75
Compare
40cdf75 to
20ae5d3
Compare
20ae5d3 to
a71276b
Compare
josephsavona
approved these changes
Dec 10, 2024
This was referenced Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When supporting ref as prop in #31558, I missed fixing the optimization to pass a spread-props-only props object in without an additional object copy. In the case that we have only a ref along with a spread, we cannot return only the spread object. This results in dropping the ref.
In this example
The bugged output is:
With this change we now get the correct output: