[Flight] Color and badge non-primary environments#31738
Merged
sebmarkbage merged 1 commit intofacebook:mainfrom Dec 16, 2024
Merged
[Flight] Color and badge non-primary environments#31738sebmarkbage merged 1 commit intofacebook:mainfrom
sebmarkbage merged 1 commit intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
force-pushed
the
flightenvcolor
branch
2 times, most recently
from
ff997f3 to
492ac59
Compare
sebmarkbage
force-pushed
the
flightenvcolor
branch
from
492ac59 to
22ad1ec
Compare
sebmarkbage
force-pushed
the
flightenvcolor
branch
from
22ad1ec to
4e9c5f3
Compare
sebmarkbage
force-pushed
the
flightenvcolor
branch
from
4e9c5f3 to
0aa0aee
Compare
eps1lon
approved these changes
Dec 16, 2024
unstubbable
approved these changes
Dec 16, 2024
Collaborator
unstubbable
left a comment
unstubbable
left a comment
There was a problem hiding this comment.
Did you consider as an alternative to use the env as a prefix instead of a suffix? This would align it with replayed logs, and avoid two successive brackets, e.g. [Cache] ServerComponent [deduped] vs. ServerComponent [Cache] [deduped].
sebmarkbage
force-pushed
the
flightenvcolor
branch
from
0aa0aee to
8e7e6da
Compare
sebmarkbage
force-pushed
the
flightenvcolor
branch
from
8e7e6da to
09ea57d
Compare
Contributor
Author
|
This is aligning with the React DevTools tree view where it's after. |
davesnx
added a commit
to davesnx/react
that referenced
this pull request
Dec 18, 2024
…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (facebook#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (facebook#31761) Enable disableDefaultPropsExceptForClasses (facebook#31804) Turn on useModernStrictMode in test renderers (facebook#31769) [compiler][ez] Add shape for global Object.keys (facebook#31583) [compiler] Context variables as dependencies (facebook#31582) [compiler] Add fire to known React APIs (facebook#31795) [compiler] Add option for firing effect functions (facebook#31794) [compiler][be] Logger based debug printing in test runner (facebook#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (facebook#31581) [compiler] Repro for aliased captures within inner function expressions (facebook#31770) [compiler][be] Playground now compiles entire program (facebook#31774) [Flight] Color and badge non-primary environments (facebook#31738) [Flight] Emit Deduped Server Components Marker (facebook#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (facebook#31736) Clean up context access profiling experiment (facebook#31806) [Flight] Stack Parallel Components in Separate Tracks (facebook#31735) Flag for requestPaint (facebook#31805)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #31737.
When mixing environments (like "use cache" or third party RSC) it's useful to color and badge those components differently to differentiate.
I'm not putting them in separate tracks because when they do actually execute, like cache misses or third party RSCs, they behave like they're part of the same tree.