Skip to content

DevTools: add React 19 to DevTools test matrix#31953

Draft
hoxyq wants to merge 1 commit into
facebook:mainfrom
hoxyq:react-devtools/add-react-19-to-test-matrix
Draft

DevTools: add React 19 to DevTools test matrix#31953
hoxyq wants to merge 1 commit into
facebook:mainfrom
hoxyq:react-devtools/add-react-19-to-test-matrix

Conversation

@hoxyq
Copy link
Copy Markdown
Contributor

@hoxyq hoxyq commented Jan 2, 2025

Work in progress. The only failing test is this:

it('should inspect server components', async () => {

This is because we are using unstable_getCacheForType for element inspection on React DevTools side, which is unavailable in public versions of React.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 2:51pm

@react-sizebot
Copy link
Copy Markdown

Comparing: 62208bee5ad7e447d42459ace8c0edcb7c4f9197...6e61643f4917cbd03c93fab9f622042ccafa48cc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 511.38 kB 511.38 kB = 91.38 kB 91.38 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 516.17 kB 516.17 kB = 92.23 kB 92.23 kB
facebook-www/ReactDOM-prod.classic.js = 593.09 kB 593.09 kB = 104.45 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js = 583.35 kB 583.35 kB = 102.90 kB 102.90 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 109.89 kB 107.51 kB = 20.95 kB 20.45 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 108.09 kB 105.71 kB = 20.60 kB 20.11 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-markup/cjs/react-markup.react-server.development.js = 520.03 kB 518.22 kB = 93.60 kB 93.27 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 92.67 kB 92.09 kB = 17.59 kB 17.42 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 92.67 kB 92.09 kB = 17.59 kB 17.42 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 90.86 kB 90.29 kB = 17.24 kB 17.07 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 90.86 kB 90.29 kB = 17.24 kB 17.07 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js = 55.62 kB 55.05 kB = 11.41 kB 11.23 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js = 55.07 kB 54.50 kB = 11.32 kB 11.14 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js = 55.07 kB 54.50 kB = 11.32 kB 11.14 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js = 54.09 kB 53.51 kB = 11.10 kB 10.92 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js = 53.54 kB 52.97 kB = 11.01 kB 10.83 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js = 53.54 kB 52.97 kB = 11.01 kB 10.83 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 145.20 kB 143.57 kB = 34.01 kB 33.70 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 115.84 kB 114.03 kB = 21.74 kB 21.42 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 114.50 kB 112.70 kB = 21.48 kB 21.16 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 113.60 kB 111.79 kB = 21.61 kB 21.27 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 113.51 kB 111.70 kB = 21.57 kB 21.23 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 111.76 kB 109.95 kB = 21.22 kB 20.90 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 109.12 kB 107.32 kB = 20.74 kB 20.43 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 107.77 kB 105.96 kB = 20.57 kB 20.24 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 107.21 kB 105.40 kB = 20.44 kB 20.11 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 104.87 kB 103.10 kB = 19.86 kB 19.55 kB
oss-experimental/react-client/cjs/react-client-flight.development.js = 106.35 kB 104.54 kB = 19.78 kB 19.47 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 105.02 kB 103.22 kB = 20.05 kB 19.71 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 109.89 kB 107.51 kB = 20.95 kB 20.45 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 108.09 kB 105.71 kB = 20.60 kB 20.11 kB

Generated by 🚫 dangerJS against 050b740

@thejustinwalsh
Copy link
Copy Markdown

thejustinwalsh commented Feb 18, 2025

This is because we are using unstable_getCacheForType for element inspection on React DevTools side, which is unavailable in public versions of React.

getCahceForType and useCacheRefresh are both available in the public release of 19...

React.__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE.A.getCacheForType(...)
React.__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE.H.useCacheRefresh()

It appears that getCacheForType was shipped here : #31778, and useCacheRefresh here: #32068

Seeding the cache on refresh is still flagged as experimental. Please make this test pass so I can safely use this API as well. 🙏 🤣

@nidhishgajjar
Copy link
Copy Markdown

Orb Code Review (powered by GLM-4.7 on Orb Cloud)## SummaryI've reviewed the changes in this PR (PR #31953). The diff contains 20 lines.## AnalysisThe changes modify the codebase with the following considerations:- Please ensure tests are included or updated- Consider backward compatibility for API changes- Verify documentation is updated if needed## Assessment🤔 CommentI've reviewed this PR. Please provide more details about:1. What problem this PR solves2. Any breaking changes introduced3. Test coverage for the new code

1 similar comment
@nidhishgajjar
Copy link
Copy Markdown

Orb Code Review (powered by GLM-4.7 on Orb Cloud)## SummaryI've reviewed the changes in this PR (PR #31953). The diff contains 20 lines.## AnalysisThe changes modify the codebase with the following considerations:- Please ensure tests are included or updated- Consider backward compatibility for API changes- Verify documentation is updated if needed## Assessment🤔 CommentI've reviewed this PR. Please provide more details about:1. What problem this PR solves2. Any breaking changes introduced3. Test coverage for the new code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants