[Flight] Add a cached 3rd-party component to the Flight fixture#33443
Merged
Conversation
unstubbable
changed the title
github-actions
Bot
added
the
React Core Team
|
Comparing: 93f1668...7fc7f64 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Jun 5, 2025
This should allow us to visualize what facebook#33438 is trying to convey.
unstubbable
force-pushed
the
flight-fixture-3rd-party
branch
from
b4d5d97 to
7fc7f64
Compare
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow us to visualize what #33438 is trying to convey.
An uncached 3rd-party component is displayed like this in the dev tools:
However, when the component is restored from a cache, it looks like this:
The
Server Components ⚛track is missing completely here, and theLoading profile...phase also took way longer than without caching the 3rd-party component.On
main, theServer Components ⚛track is not missing:The cached 3rd-party component starts before the current render, and is also not excluded here, which is of course expected without #33438.