[compiler] Fix missing dependency in eslint-plugin-react-hooks#34287
Merged
eps1lon merged 1 commit intofacebook:mainfrom Aug 25, 2025
Merged
[compiler] Fix missing dependency in eslint-plugin-react-hooks#34287eps1lon merged 1 commit intofacebook:mainfrom
eps1lon merged 1 commit intofacebook:mainfrom
Conversation
|
Comparing: 9eede45...63feb94 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto
approved these changes
Aug 25, 2025
| "@babel/core": "^7.24.4", | ||
| "@babel/parser": "^7.24.4", | ||
| "@babel/plugin-transform-private-methods": "^7.24.4", | ||
| "@babel/plugin-proposal-private-methods": "^7.18.6", |
Member
There was a problem hiding this comment.
this package seems deprecated. rather than update the package here, could you try updating react/packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.ts to use @babel/plugin-transform-private-methods instead?
Collaborator
Author
There was a problem hiding this comment.
Good point. I didn't know. Though this was attempted before and reverted in #31665 so I don't think that's safe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#34176 introduced
@babel/plugin-proposal-private-methods:react/packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.ts
Line 13 in 63feb94
However, the declared dependencies of
eslint-plugin-react-hooksweren't updated.This mostly worked for package managers that hoist everything but breaks when node_modules are strictly isolated to the set of declared dependencies.
I declared the used dependency in this PR. Could also be possible to use the transform directly.
Fixes
Test plan
packageExtensionsto make the error go away (vercel/next.js@5b2b3a5)