Skip to content

[playground] Config panel quality fixes#34611

Merged
EugeneChoi4 merged 7 commits into
facebook:mainfrom
EugeneChoi4:config-fix
Oct 3, 2025
Merged

[playground] Config panel quality fixes#34611
EugeneChoi4 merged 7 commits into
facebook:mainfrom
EugeneChoi4:config-fix

Conversation

@EugeneChoi4
Copy link
Copy Markdown
Contributor

Fixed two small issues with the config panel in the compiler playground:

  1. Object descriptions were being confined in the config box and most of it would not be visible upon hover
  2. Changed it so that "Applied Configs" would only display a valid set of configs, rather than switching between "Invalid Configs" and the set of options. This would be less visually jarring for users as the Output panel already displays errors. Additionally, if users want to see the list of config options but have a currently broken config, they would previously not know how to fix it.

Object hover before:
Screenshot 2025-09-26 at 10 41 03 AM
Hover after:
Screenshot 2025-09-26 at 10 40 37 AM

Applied Configs always displays the last valid set of configs:

Screen.Recording.2025-09-26.at.11.39.09.AM.mov

@meta-cla meta-cla Bot added the CLA Signed label Sep 26, 2025
@EugeneChoi4 EugeneChoi4 requested review from jackpope, mofeiZ and poteto and removed request for jackpope and poteto September 26, 2025 15:45
Comment thread compiler/apps/playground/components/Editor/ConfigEditor.tsx Outdated
@EugeneChoi4 EugeneChoi4 force-pushed the config-fix branch 3 times, most recently from 7d368b1 to a59512f Compare September 29, 2025 16:02
@facebook facebook deleted a comment from react-sizebot Sep 29, 2025
@EugeneChoi4 EugeneChoi4 merged commit 0eebd37 into facebook:main Oct 3, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants