[Fiber] Make server rendering tests pass#8372
Merged
sebmarkbage merged 2 commits intofacebook:masterfrom Nov 23, 2016
Merged
Conversation
sophiebits
approved these changes
Nov 22, 2016
|
|
||
| var expectedMarkup = lastMarkup; | ||
| if (ReactDOMFeatureFlags.useFiber) { | ||
| var reactMetaData = /\s+data-react[a-z-]+=\"[^\"]*\"/g; |
We need this because it runs the injection.
This markup is testing implementation details rather than behavior.
sebmarkbage
force-pushed
the
fiberserver
branch
from
062a97e to
72f1388
Compare
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
* Use the public ReactDOMServer in tests We need this because it runs the injection. * Let Fiber skip react data attributes and comments in SSR tests This markup is testing implementation details rather than behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't actually mean that reviving works but tests pass because we're not actually testing any reviving behavior.
This still doesn't pass the render into a document root tests because that actually requires reviving.