Adding new SSR tests for context, refs, and reviving markup.#9257
Merged
sophiebits merged 1 commit intofacebook:masterfrom Mar 26, 2017
Merged
Conversation
sophiebits
approved these changes
Mar 26, 2017
Collaborator
sophiebits
left a comment
sophiebits
left a comment
There was a problem hiding this comment.
I think this looks great, especially thanks for the lifecycle timing and mismatches-on-whitespace ones.
| it('can distinguish an empty component from an empty text component', () => | ||
| expectMarkupMismatch(<div><EmptyComponent /></div>, <div>{''}</div>)); | ||
|
|
||
| it('should reconnect if component trees differ but resulting markup is the same', () => { |
Collaborator
There was a problem hiding this comment.
Is this different from, ex: the ES6 vs Pure test above?
Contributor
Author
There was a problem hiding this comment.
Good question! I could argue that it's a little different, in that it's comparing two different React.Component class implementations against each other, which wasn't done above, but yeah, it's probably duplicative and has a very low (maybe zero?) likelihood of catching something not caught by those tests. I can take it out in the next PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a latest chapter in a series of PRs adding server-side rendering unit tests (following on #9055, #9089, #9106, and #9221).
This PR adds SSR tests for context, refs, and markup mismatch warnings when reviving.
If we end up implementing the new SSR as a Fiber renderer, then the context tests are probably not needed, as I'm guessing that Fiber handles context by itself and is well tested. If we write SSR from scratch, though, those tests will be useful.
Also, while I found all these tests useful when I wrote my custom server renderer, I totally understand if you find them repetitive, especially the ones that repeat tests for both class components and stateless components. Just let me know what you think!