Remove IE8-specific shorthand style property logic#9294
Closed
aweary wants to merge 1 commit intofacebook:masterfrom
Closed
Remove IE8-specific shorthand style property logic#9294aweary wants to merge 1 commit intofacebook:masterfrom
aweary wants to merge 1 commit intofacebook:masterfrom
Conversation
Contributor
Author
|
Older versions of iOS and Android are giving me trouble here, so I'm closing this. Will likely open another PR with a reduced implementation of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logic was only here for IE8. Setting
.stype[prop]for shorthand properties works fine in all other tested browsers.Testing strategy
Used the following snippet to verify shorthand property behavior
Tested Browsers
Verified all listed browsers behaved as expected (unset the shorthand style property)
edit I updated the test to be more robust and noticed that
fontdoes not work in Android Browser for Android 4.1 or iOS 4. We may still need this if we support those browsers, though we should be able to remove a number of the properties.