Merged
Conversation
This combines RBAC with OAuth authorization, so that general mdp messages can be signed in a cryptographically secure way, such that any arbitrary receiver (such as a Worker) can verify that the message belongs to a user that has access to a certain role. This is implemented with state of the art elliptic curve cryptography by signing the message with a private key, and uploading the public key to a key store worker which hands out all public keys as a service via access over the key's hash. Any receiver can then retrieve the public key by just asking for the key's hash, which is always included in the RBAC data field of any signed message (plus of course the data needed for signing). Special care is taken to avoid cross-referencing public keys to specific users. As soon as the OAuth flow is finished, any public key can no longer be used to pinpoint a specific user, instead the keystore only holds the data which role this key belongs to. This implements and closes #349. Signed-off-by: Magnus Groß <magnus.gross@kdab.com>
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
vimpostor
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
RalphSteinhagen
approved these changes
Dec 3, 2024
Member
There was a problem hiding this comment.
@vimpostor thanks for the core implementation. Looks good as is. However, CI needs to pass before being merged (missing cmake dependencies do not seem to be included).
Next step for us would be to integrate the different role and hash checks in the different worker implementation (another to be created issue).
Signed-off-by: Magnus Groß <magnus.gross@kdab.com>
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
had a problem deploying
to
configure coverage
GitHub Actions
Failure
vimpostor
requested a deployment
to
configure coverage
GitHub Actions
In progress
vimpostor
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
Signed-off-by: Magnus Groß <magnus.gross@kdab.com>
vimpostor
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
vimpostor
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
vimpostor
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
vimpostor
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
vimpostor
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
vimpostor
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
|
Member
|
@vimpostor thanks for adding the cmake entry for lib sodium! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to #349 and to the commit message for more info.