Skip to content

Fix localization issues preventing strings from being translated #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joedolson merged 1 commit into from
Jun 8, 2025
Merged

Fix localization issues preventing strings from being translated #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions inc/updater/class-lite.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ protected function append_theme_actions_content( $theme ) {
<?php
printf(
/* translators: %s: theme name */
esc_html__( 'There is a new version of %s available.', 'git-updater-lite' ),
esc_html__( 'There is a new version of %s available.', 'fair' ),
esc_attr( $theme->name )
);
printf(
Expand All @@ -396,25 +396,25 @@ protected function append_theme_actions_content( $theme ) {
if ( ! empty( $current->response[ $theme->slug ]['package'] ) ) {
printf(
/* translators: 1: version number, 2: closing anchor tag, 3: update URL */
esc_html__( 'View version %1$s details%2$s or %3$supdate now%2$s.', 'git-updater-lite' ),
esc_html__( 'View version %1$s details%2$s or %3$supdate now%2$s.', 'fair' ),
$theme->remote_version = isset( $theme->remote_version ) ? esc_attr( $theme->remote_version ) : null,
'</a>',
sprintf(
/* translators: %s: theme name */
'<a aria-label="' . esc_html__( 'Update %s now', 'git-updater-lite' ) . '" id="update-theme" data-slug="' . esc_attr( $theme->slug ) . '" href="' . esc_url( $nonced_update_url ) . '">',
'<a aria-label="' . esc_html__( 'Update %s now', 'fair' ) . '" id="update-theme" data-slug="' . esc_attr( $theme->slug ) . '" href="' . esc_url( $nonced_update_url ) . '">',
esc_attr( $theme->name )
)
);
} else {
printf(
/* translators: 1: version number, 2: closing anchor tag, 3: update URL */
esc_html__( 'View version %1$s details%2$s.', 'git-updater-lite' ),
esc_html__( 'View version %1$s details%2$s.', 'fair' ),
$theme->remote_version = isset( $theme->remote_version ) ? esc_attr( $theme->remote_version ) : null,
'</a>'
);
printf(
/* translators: %s: opening/closing paragraph and italic tags */
esc_html__( '%1$sAutomatic update is unavailable for this theme.%2$s', 'git-updater-lite' ),
esc_html__( '%1$sAutomatic update is unavailable for this theme.%2$s', 'fair' ),
'<p><i>',
'</i></p>'
);
Expand Down
2 changes: 1 addition & 1 deletion inc/version-check/namespace.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function get_browser_check_response( string $agent ) {
],
'body' => json_encode( [
'platform' => _x( 'your platform', 'browser version check', 'fair' ),
'name' => __( 'your browser', 'browser version check', 'fair' ),
'name' => _x( 'your browser', 'browser version check', 'fair' ),
'version' => '',
'current_version' => '',
'upgrade' => ! $supported,
Expand Down