Change type definition on notify_users to allow for null input

[topher1kenobe]

Change
function notify_users( string $content = '' ) : string {

to
function notify_users( string|null $content = '' ) : string {

[szepeviktor]

Is that PHP 7.4 compatible?

[topher1kenobe]

Is that PHP 7.4 compatible?

Ah no, sorry. I'll adjust.

[topher1kenobe]

I'm not sure why my commits aren't signed. I signed them, and saw the signage in the commit message.

[szepeviktor]

The DCO bot wants you to add Signed-off-by to your commit message, not a digital signature.

[topher1kenobe]

The DCO bot wants you to add Signed-off-by to your commit message, not a digital signature.

I'm aware. That didn't work and I don't know why.

[szepeviktor]

👉🏻 https://github.com/fairpm/fair-plugin/pull/34/checks

[topher1kenobe]

👉🏻 https://github.com/fairpm/fair-plugin/pull/34/checks

I read that, and followed those instructions. That's how we got here.

[Ipstenu]

@topher1kenobe The problem is you have two commits that weren’t signed off. I had the same problem when I messed up signing one and the whole PR held on to it.

Did you do this part? The force push was the only way to fix it.

To add your Signed-off-by line to every commit in this branch:

1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
2. In your local branch, run: git rebase HEAD~4 --signoff
3. Force push your changes to overwrite the branch: git push --force-with-lease origin issue-33/allow-null-input-on-dashboard

[topher1kenobe]

@topher1kenobe The problem is you have two commits that weren’t signed off. I had the same problem when I messed up signing one and the whole PR held on to it.

Did you do this part? The force push was the only way to fix it.

To add your Signed-off-by line to every commit in this branch:

1. Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).

2. In your local branch, run: `git rebase HEAD~4 --signoff`

3. Force push your changes to overwrite the branch: `git push --force-with-lease origin issue-33/allow-null-input-on-dashboard`

I had tried this once before, but I've done it again. We'll see if it works.

[Ipstenu]

That worked! Looks like it never properly force pushed. No worries, git can get weird.

I’m doing a scan to see how common this error is in plugins. Regardless I think this is a good fix. Should/can we toss in a “doing it wrong” notice for the devs?

[szepeviktor]

Docblock change and null handling is mmissing.