Support ClassicPress News widget#65
Merged
joedolson merged 5 commits intofairpm:mainfrom Jun 12, 2025
xxsimoxx:classicpress
Merged
Support ClassicPress News widget#65joedolson merged 5 commits intofairpm:mainfrom xxsimoxx:classicpress
joedolson merged 5 commits intofairpm:mainfrom
xxsimoxx:classicpress
Conversation
added 3 commits
June 10, 2025 14:42
Signed-off-by: xxsimoxx <simone@gieffeedizioni.it>
Signed-off-by: xxsimoxx <simone@gieffeedizioni.it>
Signed-off-by: xxsimoxx <simone@gieffeedizioni.it>
joedolson
requested changes
Jun 10, 2025
Member
joedolson
left a comment
joedolson
left a comment
There was a problem hiding this comment.
I think it would be better to check ! function_exists( 'wp_print_community_events_markup' ), as that would support any case where this was removed, rather than being specific to Classic Press. Thoughts?
timiwahalahti
added
the
compatibility-issue
Ipstenu
requested changes
Jun 11, 2025
Signed-off-by: xxsimoxx <simone@gieffeedizioni.it>
Contributor
Author
|
Sure, I agree to the proposed change and just pushed a commit. |
szepeviktor
approved these changes
Jun 11, 2025
Ipstenu
approved these changes
Jun 11, 2025
Signed-off-by: Joe Dolson <design@joedolson.com>
joedolson
approved these changes
Jun 12, 2025
Member
joedolson
left a comment
joedolson
left a comment
There was a problem hiding this comment.
I added a comment to provide context for this, as I can easily imagine future me saying "why would this function not exist?"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassicPress is a fork of WordPress, without blocks.
Since ClassicPress have it's own news system, this prevents a fatal error in the dashboard.
wp_print_community_events_markup()is not present in ClassicPress as the Community Events widget.Before
After