Skip to content

Fix bitvec dependencies#238

Merged
h4sh3d merged 3 commits intofarcaster-project:mainfrom
nickf12:bitvec-1.0.0_requirements
Jun 29, 2022
Merged

Fix bitvec dependencies#238
h4sh3d merged 3 commits intofarcaster-project:mainfrom
nickf12:bitvec-1.0.0_requirements

Conversation

@nickf12
Copy link
Contributor

@nickf12 nickf12 commented Jun 3, 2022

This pull request is to fix the compilation errors of #212 in order to upgrade bitvec's dependencies to the latest version. I have done below modifications to crypto/dleq.rs:

  • Modified the order of BitSlice's parameters accordingly with the latest version as it is expecting the following input format <u8, Lsb0>
  • Removed unwrap() as already called in bitvec from_slice() function

@nickf12 nickf12 changed the title Update bitvec requirement from 0.22.3 to 1.0.0 Fix bitvec dependencies Jun 3, 2022
@h4sh3d
Copy link
Member

h4sh3d commented Jun 7, 2022

Needs a rebase to review real changes

@nickf12 nickf12 force-pushed the bitvec-1.0.0_requirements branch from 447f50d to 50f20a8 Compare June 9, 2022 09:33
@nickf12
Copy link
Contributor Author

nickf12 commented Jun 9, 2022

Rebase completed.

@h4sh3d h4sh3d changed the base branch from dependabot/cargo/bitvec-1.0.0 to main June 10, 2022 13:39
Copy link
Member

@h4sh3d h4sh3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@nickf12
Copy link
Contributor Author

nickf12 commented Jun 21, 2022

Hi @h4sh3d,
I have updated the code for the CI, now all the tests should pass.

@h4sh3d h4sh3d merged commit 2ae6ae4 into farcaster-project:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants