refactor: split crypto sign trait and clean crypto module#256
Merged
sedited merged 5 commits intofarcaster-project:mainfrom Jul 11, 2022
Merged
Conversation
Split `Sign` trait into: `Sign`, `EncSig`, and `RecoverKey` to allow less generic arguments.
h4sh3d
force-pushed
the
refactor/split-crypto-sign-trait
branch
from
21eb49e to
3e25cc0
Compare
sedited
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #255
Diff starts at e287d1e.
Split the
Signtrait to be more specific about requirements inprotocolfunctions. RemoveSignaturestrait because it became useless after #255 refactor. ImproveCommittrait.