feat: new offer uuid and fingerprint#292
Merged
sedited merged 3 commits intofarcaster-project:mainfrom Aug 14, 2022
Merged
Conversation
sedited
requested changes
Aug 10, 2022
tests/negotiation.rs
Outdated
| PublicOffer<bitcoin::Amount, monero::Amount, CSVTimelock, SatPerVByte>, | ||
| consensus::Error, | ||
| > = deserialize(&hex::decode(invalid).unwrap()[..]); | ||
| > = deserialize(&hex::decode(inval).unwrap()[..]); |
Member
Author
There was a problem hiding this comment.
Was to keep the same number of chars as 'valid' for the alignment :)
Done in dae4459
Contributor
|
Is there something we can do to get strict encoding for the UUID alone? Maybe wrap it in a struct? |
Member
Author
I thought about it. It is not the nicest but |
h4sh3d
force-pushed
the
feat/offer-uuid
branch
from
dae4459 to
ba0f91f
Compare
sedited
approved these changes
Aug 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch behavior from offer id and public offer id computed as hash of serialized content to standalone
uuidfield inOffertype.A new function
.fingerprint()is introduced to match the previous behavior of.id().