[DO NO MERGE] feat: Upgrade malachite to latest version#550
Open
sanjayprabhu wants to merge 4 commits intomainfrom
Open
[DO NO MERGE] feat: Upgrade malachite to latest version#550sanjayprabhu wants to merge 4 commits intomainfrom
sanjayprabhu wants to merge 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aditiharini
reviewed
Jun 20, 2025
| )); | ||
| } | ||
|
|
||
| Msg::NewEvent(Event::ConsensusMessage(channel, from, _)) => { |
Contributor
There was a problem hiding this comment.
What are these messages we're ignoring? Is it possible to enumerate the Channel::... explicitly so it's easier to understand?
aditiharini
reviewed
Jun 20, 2025
| sync.cast(read_sync::Msg::Decided(state.validator.last_height))? | ||
| let decided_height = state.validator.last_height; | ||
| sync.cast(read_sync::Msg::Decided(decided_height))?; | ||
| sync.cast(read_sync::Msg::Started(decided_height.increment()))? |
Contributor
There was a problem hiding this comment.
Is Started new? Why do we need it?
aditiharini
reviewed
Jun 20, 2025
| pub enum Msg { | ||
| /// Internal tick | ||
| Tick { reply_to: Option<RpcReplyPort<()>> }, | ||
| Tick { |
sanjayprabhu
force-pushed
the
malachite_upgrade
branch
from
80fd716 to
b45b323
Compare
Contributor
Author
|
Blocked on a few malachite fixes: https://github.com/informalsystems/malachite/issues/1139 |
sanjayprabhu
force-pushed
the
malachite_upgrade
branch
from
b45b323 to
17b2d3f
Compare
sanjayprabhu
force-pushed
the
malachite_upgrade
branch
from
17b2d3f to
40d8024
Compare
sanjayprabhu
force-pushed
the
malachite_upgrade
branch
from
40d8024 to
0e7517b
Compare
sanjayprabhu
force-pushed
the
malachite_upgrade
branch
from
0e7517b to
1b8c40d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade malachite to latest version so we can use the following features:
This will help fix #513 and #512
Test plan: