📝 Update documentation to refer to list instead of List#1147
Merged
tiangolo merged 4 commits intofastapi:mainfrom Feb 28, 2025
Merged
📝 Update documentation to refer to list instead of List#1147tiangolo merged 4 commits intofastapi:mainfrom
list instead of List#1147tiangolo merged 4 commits intofastapi:mainfrom
Conversation
List instead of listList instead of list
Contributor
|
📝 Docs preview for commit 74008c6 at: https://55dfa7c7.sqlmodel.pages.dev Modified Pages |
List instead of listlist instead of List
svlandeg
reviewed
Feb 24, 2025
Member
svlandeg
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Yes - this is a good catch. The older Python 3.7 examples do use List, but it makes sense to update the surrounding text to reflect the newest examples. In fact, I searched through the documentation and there's more cases like this, still referring to List. I'll take this opportunity to update all of them.
Contributor
|
📝 Docs preview for commit 7ba67fa at: https://471b13fc.sqlmodel.pages.dev Modified Pages |
Contributor
svlandeg
approved these changes
Feb 24, 2025
Contributor
tiangolo
approved these changes
Feb 28, 2025
Member
tiangolo
left a comment
There was a problem hiding this comment.
Great, thank you @bubbletroubles and @svlandeg! 🤓 🍰
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the examples use lowercase
list, but this text referrers toList(which is imported from Typing).I suspect it's supposed to be lowercase.