Redefine .noColor field of Color, NO_COLOR won't affect at runtime#267
Open
SourLemonJuice wants to merge 3 commits into
Open
Redefine .noColor field of Color, NO_COLOR won't affect at runtime#267SourLemonJuice wants to merge 3 commits into
SourLemonJuice wants to merge 3 commits into
Conversation
Redefine the ".noColor *bool" field to ".useColor bool" of type "Color", this removed the pointless pointer and reduced the complexity. Which also removed the boolPtr() method(?) The test "TestNoColor_Env" now removed, because the NO_COLOR env should not affect at runtime.
SourLemonJuice
added a commit
to SourLemonJuice/ipapi-agent
that referenced
this pull request
Sep 29, 2025
Replace fatih/color with my fork version, which fixes the force color output issue. PR: fatih/color#267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redefine the ".noColor *bool" field to ".isNoColor bool" of type "Color", this removed the pointless pointer and reduced the complexity.
Which also removed the boolPtr() method(?)
The test "TestNoColor_Env" now removed, because the NO_COLOR env should not affect at runtime.
In my software, I want to force output through HTTP with color(client is curl), but each time
New()will always useNO_COLORenv without any judgment, #71 can't work.In the previous code,
New()even will ignore the globalNoColorstatus. This is confusion caused by the function's naming.