Skip to content

Fix integration testing config#174

Closed
zhilingc wants to merge 6 commits into
feast-dev:masterfrom
zhilingc:fix-prow-config
Closed

Fix integration testing config#174
zhilingc wants to merge 6 commits into
feast-dev:masterfrom
zhilingc:fix-prow-config

Conversation

@zhilingc
Copy link
Copy Markdown
Collaborator

  1. Added rerun command and corrected trigger command
  2. Fixed integration test image

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zhilingc

If they are not already assigned, you can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Copy Markdown
Collaborator Author

/test integration-batch

@zhilingc
Copy link
Copy Markdown
Collaborator Author

/retest

@zhilingc
Copy link
Copy Markdown
Collaborator Author

/test integration-batch

@zhilingc
Copy link
Copy Markdown
Collaborator Author

/retest

1 similar comment
@zhilingc
Copy link
Copy Markdown
Collaborator Author

/retest

@thirteen37
Copy link
Copy Markdown
Collaborator

Related to #102?

@zhilingc
Copy link
Copy Markdown
Collaborator Author

@thirteen37 No, this fixes some issues with the running of the integration test via CI. The triggering is already working as intended, although the integration test step is not properly throwing an error when the test fails. The changes made in this commit should fix that.

See the latest postsubmit-integration-test here: http://prow.feast.ai/

@thirteen37
Copy link
Copy Markdown
Collaborator

@zhilingc Sounds like you're saying that #102 is actually resolved then? Can we mark it as such or is there more work remaining?

@zhilingc
Copy link
Copy Markdown
Collaborator Author

@thirteen37 Not quite, I need this fix in so that it does throw an error when one occurs, otherwise the integration test (that does the building of the binaries) will always pass

@davidheryanto
Copy link
Copy Markdown
Collaborator

Closed by #197

patelchaitany pushed a commit to patelchaitany/feast that referenced this pull request Mar 25, 2026
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants