Skip to content

Update Quickstart#184

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
pradithya:quickstart_update
Apr 29, 2019
Merged

Update Quickstart#184
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
pradithya:quickstart_update

Conversation

@pradithya
Copy link
Copy Markdown
Collaborator

Update Python SDK quickstart after removing granularity

Copy link
Copy Markdown
Collaborator

@zhilingc zhilingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick regarding the port numbers, looks great other than that :)

Comment thread sdk/python/examples/quickstart/Quickstart.ipynb
Copy link
Copy Markdown
Collaborator

@davidheryanto davidheryanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zhilingc
Copy link
Copy Markdown
Collaborator

/lgtm

@pradithya
Copy link
Copy Markdown
Collaborator Author

/approve

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit c388b3e into feast-dev:master Apr 29, 2019
zhilingc added a commit that referenced this pull request Apr 29, 2019
feast-ci-bot pushed a commit that referenced this pull request Apr 29, 2019
aniketpalu pushed a commit to aniketpalu/feast that referenced this pull request Jan 25, 2026
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
aniketpalu pushed a commit to aniketpalu/feast that referenced this pull request Mar 2, 2026
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
aniketpalu pushed a commit to aniketpalu/feast that referenced this pull request Mar 2, 2026
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants