Skip to content

Remove redis transaction#280

Merged
pradithya merged 1 commit into
feast-dev:0.1.xfrom
pradithya:remove_transaction
Oct 30, 2019
Merged

Remove redis transaction#280
pradithya merged 1 commit into
feast-dev:0.1.xfrom
pradithya:remove_transaction

Conversation

@pradithya
Copy link
Copy Markdown
Collaborator

Motivation:

We are setting up sharded with twemproxy in front of it. However, twemproxy doesn't support transaction (https://github.com/twitter/twemproxy/blob/master/notes/redis.md)

Modification:

  • Remove transaction in RedisCustomIO

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pradithya
Copy link
Copy Markdown
Collaborator Author

/assign @davidheryanto

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

@pradithya: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-core-and-ingestion 74bff10 link /test test-core-and-ingestion
test-serving 74bff10 link /test test-serving
test-java-sdk 74bff10 link /test test-java-sdk
test-golang-sdk 74bff10 link /test test-golang-sdk
test-python-sdk 74bff10 link /test test-python-sdk
test-end-to-end 74bff10 link /test test-end-to-end

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhilingc
Copy link
Copy Markdown
Collaborator

/lgtm

@pradithya
Copy link
Copy Markdown
Collaborator Author

I'll merge manually since the test doesn't work

@pradithya pradithya merged commit 82569b0 into feast-dev:0.1.x Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants