Use Maven's --also-make by default#308
Conversation
This is especially helpful for IntelliJ to work the way you expect. References #294
ches
requested review from
davidheryanto,
pradithya,
thirteen37,
tims,
woop and
zhilingc
as code owners
|
Hi @ches. Thanks for your PR. I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@ches: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @ches This is great. I have run into dependency issues myself between core and ingestion. Should be safe to try out. Only pain is the eye sore of |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ches, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
I realized that Maven has a project-local config file where
--also-makecould be turned on always, and this is especially helpful for IntelliJ users because the IDE picks it up: it ends the breakage where the Build Project button or running tests error out because of not resolving core's dependency on ingestion. I had tried to find a way to tell it to consistently do this, and it turns out an answer lies outside of IntelliJ.So far I haven't encountered cases where having this always-on causes issue for Maven operations I've run by CLI or IDE, but let me know if you run into any, and let's see how CI goes.
The
CONTRIBUTING.mdstill has redundancy that I'm consolidating along with Docker Compose instructions for #272, but I did remove the instructions tocdinto subdirectories in reference to #294.