Skip to content

Consolidate jobs into single steps instead of branching out#326

Merged
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
zhilingc:temp-fix-jobs
Nov 27, 2019
Merged

Consolidate jobs into single steps instead of branching out#326
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
zhilingc:temp-fix-jobs

Conversation

@zhilingc
Copy link
Copy Markdown
Collaborator

The current ingestion job graph is built such that each distinct feature set has its own subgraph; branching is done by tagging each incoming feature row.

This has resulted in the following 2 problems:

  1. With large amounts of features the graph balloons in size - so much so that the job is unable to be submitted to dataflow.
  2. Inability to update jobs with metrics enabled, since the type for the metrics step is changed between updates

This PR consolidates the steps such that all feature rows follow the same path through the graph.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Copy Markdown
Collaborator Author

/retest

@zhilingc
Copy link
Copy Markdown
Collaborator Author

/retest

@zhilingc
Copy link
Copy Markdown
Collaborator Author

/retest

@woop
Copy link
Copy Markdown
Member

woop commented Nov 27, 2019

/lgtm

@feast-ci-bot feast-ci-bot merged commit e54780b into feast-dev:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants