Skip to content

Add testing folder for deploying test infrastructure and running tests#34

Merged
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
woop:test-infra
Jan 4, 2019
Merged

Add testing folder for deploying test infrastructure and running tests#34
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
woop:test-infra

Conversation

@woop
Copy link
Copy Markdown
Member

@woop woop commented Jan 3, 2019

This PR sets up unit testing using Prow, for issue #2

@woop woop changed the title Test infra Add testing folder deploying test infrastructure and running tests Jan 3, 2019
@woop woop changed the title Add testing folder deploying test infrastructure and running tests Add testing folder for deploying test infrastructure and running tests Jan 3, 2019
@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 3, 2019

/test presubmit-unit-tests

1 similar comment
@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 3, 2019

/test presubmit-unit-tests

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 3, 2019

/hold

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 3, 2019

/assign tims

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 3, 2019

/assign zhilingc

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 3, 2019

/hold cancel

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 3, 2019

/retest

1 similar comment
@tims
Copy link
Copy Markdown
Contributor

tims commented Jan 3, 2019

/retest

tims
tims reviewed Jan 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@tims tims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tims
Copy link
Copy Markdown
Contributor

tims commented Jan 3, 2019

/approve

@feast-ci-bot feast-ci-bot added approved and removed lgtm labels Jan 3, 2019
@tims
Copy link
Copy Markdown
Contributor

tims commented Jan 3, 2019

/lgtm

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 3, 2019

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jan 3, 2019

@woop: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot feast-ci-bot removed the lgtm label Jan 4, 2019
@feast-dev feast-dev deleted a comment from feast-ci-bot Jan 4, 2019
@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 4, 2019 •
edited
Loading

/retest

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 4, 2019

/retest

1 similar comment
@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 4, 2019

/retest

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 4, 2019

/approve

@zhilingc
Copy link
Copy Markdown
Collaborator

zhilingc commented Jan 4, 2019

/lgtm

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 4, 2019

/assign zhilingc

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 4, 2019

/cc zhilingc

@feast-ci-bot feast-ci-bot requested a review from zhilingc January 4, 2019 02:45
@zhilingc
Copy link
Copy Markdown
Collaborator

zhilingc commented Jan 4, 2019

/accept

zhilingc
zhilingc approved these changes Jan 4, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@zhilingc zhilingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual approve

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 4, 2019

/uncc tims
/cc pradithya

@feast-ci-bot feast-ci-bot requested a review from pradithya January 4, 2019 02:59
@pradithya
Copy link
Copy Markdown
Collaborator

pradithya commented Jan 4, 2019

/approve

@zhilingc
Copy link
Copy Markdown
Collaborator

zhilingc commented Jan 4, 2019

/approve

@zhilingc
Copy link
Copy Markdown
Collaborator

zhilingc commented Jan 4, 2019

/approve cancel

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jan 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya, tims, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [pradithya,tims,woop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 4, 2019

Do not merge this PR. Our bad bot needs to do his job.

@feast-ci-bot feast-ci-bot merged commit ccbf615 into feast-dev:master Jan 4, 2019
@woop
Copy link
Copy Markdown
Member Author

woop commented Jan 4, 2019

You did good @feast-ci-bot

dmartinol pushed a commit to dmartinol/feast that referenced this pull request Jul 9, 2024
@redhatHameed
Merge pull request feast-dev#34 from redhatHameed/rbac-doc
13952c7 
added document reference for Permission/RBAC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradithya pradithya pradithya approved these changes

@zhilingc zhilingc zhilingc approved these changes

+1 more reviewer

@tims tims tims left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tims tims

@zhilingc zhilingc

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@woop @tims @feast-ci-bot @zhilingc @pradithya