Skip to content

docs: Fix broken Google Group link on Community page#343

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
ches:community-doc-fix
Dec 3, 2019
Merged

docs: Fix broken Google Group link on Community page#343
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
ches:community-doc-fix

Conversation

@ches
Copy link
Copy Markdown
Member

@ches ches commented Dec 3, 2019

I happened to be looking at docs and noticed this link gone funny, maybe a GitBook editor tried to Markdown-escape something pasted that was already Markdown format.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

Hi @ches. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment thread docs/community.md
* Google Group: [https://groups.google.com/d/forum/feast-dev](https://groups.google.com/d/forum/feast-dev)
* Mailing List: [feast-dev@googlegroups.com](mailto:feast-dev@googlegroups.com)
* Google Group: <https://groups.google.com/d/forum/feast-dev>
* Mailing List: <feast-dev@googlegroups.com>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a little-known feature going way back to original Markdown implementation: angle brackets for bare URLs and mailto links.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ches, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Copy Markdown
Member

woop commented Dec 3, 2019

/lgtm

@feast-ci-bot feast-ci-bot merged commit 798fd46 into feast-dev:master Dec 3, 2019
@ches ches deleted the community-doc-fix branch December 4, 2019 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants