Add documentation to default values.yaml in Feast chart#376
Merged
feast-ci-bot merged 1 commit intoDec 22, 2019
Merged
Conversation
davidheryanto
requested review from
pradithya,
thirteen37,
tims,
woop and
zhilingc
as code owners
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
/retest |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation in default values.yaml is missing in Feast chart. This pull request addresses that.
Resolve #350
In the future, there should probably be some automation / script so that the documentation for fields in
values.yamloriginates from a single source versus copy pasting it from multiple sources.For instance, most of the documentation for
feast-corefield in the defaultvalues.yamlactually comes from the feast-core subchart defaultvalues.yaml:https://github.com/gojek/feast/blob/7571ba7241c6451f4dd2718b41e4102c058fe1a1/infra/charts/feast/values.yaml#L51
https://github.com/gojek/feast/blob/7571ba7241c6451f4dd2718b41e4102c058fe1a1/infra/charts/feast/charts/feast-core/values.yaml#L102