Skip to content

Allow user to override job options#377

Merged
woop merged 1 commit into
feast-dev:masterfrom
khorshuheng:allow-jobstore-override
Dec 22, 2019
Merged

Allow user to override job options#377
woop merged 1 commit into
feast-dev:masterfrom
khorshuheng:allow-jobstore-override

Conversation

@khorshuheng
Copy link
Copy Markdown
Collaborator

Without option to override the default job options, it would not be possible to provision Redis outside of the helm chart.

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: khorshuheng
To complete the pull request process, please assign zhilingc
You can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

Hi @khorshuheng. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhilingc
Copy link
Copy Markdown
Collaborator

/lgtm

@woop
Copy link
Copy Markdown
Member

woop commented Dec 22, 2019

/retest

@woop
Copy link
Copy Markdown
Member

woop commented Dec 22, 2019

/ok-to-test

@woop
Copy link
Copy Markdown
Member

woop commented Dec 22, 2019

/approved

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

@khorshuheng: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end dc6ee96 link /test test-end-to-end

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@woop woop merged commit 98ea901 into feast-dev:master Dec 22, 2019
@woop
Copy link
Copy Markdown
Member

woop commented Dec 22, 2019

Merging this manually because tests are still failing for some reason, even though they shouldnt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants