Skip to content

Minor bug fixes for Python SDK#383

Merged
feast-ci-bot merged 1 commit into
masterfrom
minor-tweaks
Dec 23, 2019
Merged

Minor bug fixes for Python SDK#383
feast-ci-bot merged 1 commit into
masterfrom
minor-tweaks

Conversation

@voonhous
Copy link
Copy Markdown
Collaborator

@voonhous voonhous commented Dec 22, 2019

This pull request add these changes:

  • Use tmp dir when creating a temporary parquet file with a fixed row_group_size.
  • Tweak int -> ceil when determining row_group_size when creating temporary parquet file.
  • Changed imap_unordered to imap so that results returned by pool workers are ordered.

- Use tmp dir during ingest
- Tweak int to ceil for row_group_size
- Changed imap_unordered to imap so that results are ordered
@voonhous
Copy link
Copy Markdown
Collaborator Author

/retest

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: voonhous, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Copy Markdown
Member

woop commented Dec 23, 2019

/retest

@feast-dev feast-dev deleted a comment from voonhous Dec 23, 2019
@woop
Copy link
Copy Markdown
Member

woop commented Dec 23, 2019

/lgtm

@feast-ci-bot feast-ci-bot merged commit 01c4b44 into master Dec 23, 2019
@voonhous voonhous deleted the minor-tweaks branch December 23, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants