Skip to content

<docs>(concepts): change data types to upper case because lower case …#389

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
david30907d:fix-types-on-readme
Dec 24, 2019
Merged

<docs>(concepts): change data types to upper case because lower case …#389
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
david30907d:fix-types-on-readme

Conversation

@david30907d
Copy link
Copy Markdown
Contributor

…would fail when you want to apply this FeatureSet

I'm not sure this PR is appropriate or not, but the data types on README would fail when i'm trying to create my own FeatureSet. I'm thinking about maybe putting the real data types on doc?

…would fail when you want to apply this FeatureSet
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

Hi @david30907d. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhilingc
Copy link
Copy Markdown
Collaborator

Thanks for updating the docs!

@zhilingc
Copy link
Copy Markdown
Collaborator

/lgtm

@zhilingc
Copy link
Copy Markdown
Collaborator

/retest

@zhilingc
Copy link
Copy Markdown
Collaborator

/approve

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david30907d, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 51cbdc7 into feast-dev:master Dec 24, 2019
@david30907d david30907d deleted the fix-types-on-readme branch December 24, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants