Skip to content

Only lookup storage specs that we actually need#52

Merged
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
tims:selectivestoragespecs
Jan 10, 2019
Merged

Only lookup storage specs that we actually need#52
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
tims:selectivestoragespecs

Conversation

@tims
Copy link
Copy Markdown
Contributor

@tims tims commented Jan 8, 2019

Fixes #20

It does some hack with the errors store spec, which we will ultimately remove when we don't get that from core.

@tims tims requested review from pradithya and zhilingc January 8, 2019 13:47
@tims tims force-pushed the selectivestoragespecs branch from 32b4c2e to 3d6f1ca Compare January 8, 2019 14:09
Comment thread ingestion/src/test/java/feast/ingestion/service/CompositeSpecService.java Outdated
@tims tims force-pushed the selectivestoragespecs branch from 3d6f1ca to 4a9d751 Compare January 9, 2019 06:31
@pradithya
Copy link
Copy Markdown
Collaborator

@tims any chance this PR can be close? it seems it fixes #46

tims and others added 2 commits January 10, 2019 16:02
…he split main output, so they can be written downstream (eg to the warehouse)
@pradithya
Copy link
Copy Markdown
Collaborator

/retest

@pradithya
Copy link
Copy Markdown
Collaborator

/lgtm

@zhilingc
Copy link
Copy Markdown
Collaborator

/approve

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 029edb4 into feast-dev:master Jan 10, 2019
@tims tims deleted the selectivestoragespecs branch January 11, 2019 00:17
Yanson pushed a commit to Yanson/feast that referenced this pull request Jul 29, 2020
Cherry-picked upstream PR feast-dev#769

Changed WASB implementation of Azure file staging to ABFSS to support directory file enumeration, for retrieving Spark job output (collection of files) in feast-dev#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants