Remove transaction when listing projects#522
Merged
feast-ci-bot merged 1 commit intoMar 9, 2020
Merged
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidheryanto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
IMO none of these methods need to be transactional, but |
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Mar 16, 2020
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Mar 16, 2020
khorshuheng
pushed a commit
that referenced
this pull request
Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Listing projects is a read only operation and therefore should not need the
@TransactionalHibernate annotation.Having
@Transactionalannotation results in excessive locks being used when listing projects because of theINSERTandDELETEqueries generated. As a result, when other operations such as job updates (which is alsoTransactional) is running, users trying to list projects will often encounter GRPC errorTimeoutExceededbecause ListProjects will wait a long for the shared lock to be available.When there is at least one feature set registered, these are the generated queries when listing projects:
sql.with.transaction.log
sql.no.transaction.log
Without
@TransactionnoINSERTandDELETEqueries are generated and hence it will not wait for lock to be available when listing projects.Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: