Skip to content

Fix doc building #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 7 commits into from
Apr 4, 2020
Merged

Fix doc building #603

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cbfe56d
Fix documentation building
woop Apr 4, 2020
43a73a4
Add comments to documentation building
woop Apr 4, 2020
e0e4b53
Test protoc build
woop Apr 4, 2020
aed22ec
Add protoc building
woop Apr 4, 2020
bc6ace0
Add path to protoc building
woop Apr 4, 2020
ba5f2f6
Add path to protoc building
woop Apr 4, 2020
2b489b4
Build Python Protos
woop Apr 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,20 @@ install-dependencies-proto-docs:
mv protoc3/include/* $$HOME/include

compile-protos-docs:
cd ${ROOT_DIR}/protos; protoc --docs_out=../dist/grpc feast/*/*.proto
cd ${ROOT_DIR}/protos; protoc --docs_out=../dist/grpc feast/*/*.proto || \
cd ${ROOT_DIR}; $(MAKE) install-dependencies-proto-docs && cd ${ROOT_DIR}/protos; PATH=$$HOME/bin:$$PATH protoc -I $$HOME/include/ -I . --docs_out=../dist/grpc feast/*/*.proto

clean-html:
rm -rf $(ROOT_DIR)/dist

build-html: clean-html
mkdir -p $(ROOT_DIR)/dist/python
mkdir -p $(ROOT_DIR)/dist/grpc
cd $(ROOT_DIR)/protos && $(MAKE) gen-docs

# Build Protobuf documentation
$(MAKE) compile-protos-docs

# Build Python SDK documentation
$(MAKE) compile-protos-python
cd $(ROOT_DIR)/sdk/python/docs && $(MAKE) html
cp -r $(ROOT_DIR)/sdk/python/docs/html/* $(ROOT_DIR)/dist/python
cp -r $(ROOT_DIR)/sdk/python/docs/html/* $(ROOT_DIR)/dist/python