Ensure that generated python code are considered as module#679
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@khorshuheng: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
In https://github.com/gojek/feast/pull/545/files, generated python codes are no longer version controlled. Instead, the code are generated prior to Python unit tests.
However, the publish python sdk script does not include this step. As a result the published artifact does not contain the generated code.
In addition, https://github.com/gojek/feast/blob/master/sdk/python/setup.py#L70 will not be able to find the generated modules, as init.py is not auto generated.
Which issue(s) this PR fixes:
Publish Python SDK should work as intended after this fix.
Does this PR introduce a user-facing change?: