Skip to content

Ensure that generated python code are considered as module#679

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
khorshuheng:compile-proto-before-publish
May 6, 2020
Merged

Ensure that generated python code are considered as module#679
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
khorshuheng:compile-proto-before-publish

Conversation

@khorshuheng
Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
In https://github.com/gojek/feast/pull/545/files, generated python codes are no longer version controlled. Instead, the code are generated prior to Python unit tests.

However, the publish python sdk script does not include this step. As a result the published artifact does not contain the generated code.

In addition, https://github.com/gojek/feast/blob/master/sdk/python/setup.py#L70 will not be able to find the generated modules, as init.py is not auto generated.

Which issue(s) this PR fixes:
Publish Python SDK should work as intended after this fix.

Does this PR introduce a user-facing change?:


@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Copy Markdown
Member

woop commented May 6, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit a1937c3 into feast-dev:master May 6, 2020
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

@khorshuheng: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml
Details

In response to this:

What this PR does / why we need it:
In https://github.com/gojek/feast/pull/545/files, generated python codes are no longer version controlled. Instead, the code are generated prior to Python unit tests.

However, the publish python sdk script does not include this step. As a result the published artifact does not contain the generated code.

In addition, https://github.com/gojek/feast/blob/master/sdk/python/setup.py#L70 will not be able to find the generated modules, as init.py is not auto generated.

Which issue(s) this PR fixes:
Publish Python SDK should work as intended after this fix.

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants