Add grpc health probe implementation to core#680
Merged
Conversation
zhilingc
requested review from
davidheryanto,
khorshuheng,
pradithya and
woop
as code owners
Collaborator
|
/lgtm |
Collaborator
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
We should include in changelog / a migration guide that |
Member
|
For now, I've called it out as a note in the Breaking Changes section of the GitHub Release for v0.5.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changing the health probe for feast core to use grpc, and test simple functionality (retrieving projects) instead of just pinging the db.
This works well as a readiness probe, but not so much as a liveness probe since even in the event it fails, restarting the service will not help solve the problem. Additionally, grpc health probe does not allow us to differentiate between the two types of probes.
For now I have the liveness probe disabled by default in the helm chart, but I'm happy to take any suggestions regarding the problems above ^
Which issue(s) this PR fixes:
Fixes #514
Does this PR introduce a user-facing change?: