Fix pipeline options toArgs() returning empty list#765
Merged
Conversation
pyalex
approved these changes
Jun 3, 2020
Collaborator
Author
|
/lgtm |
Collaborator
|
@zhilingc: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Collaborator
|
/lgtm |
Collaborator
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Jun 5, 2020
khorshuheng
added a commit
that referenced
this pull request
Jun 7, 2020
zhangchi1
pushed a commit
to Cimpress-MCP/feast
that referenced
this pull request
Jun 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#718 broke the pipeline options - for
getFields()to work, fields must be public-access. As a result thetoArgs()method was returning an empty list.Added some tests to avoid such careless mistakes from being merged into master again.