Publish helm chart script should not modify the chart content#779
Conversation
d9b8927 to
ea4ed7e
Compare
ea4ed7e to
7c3e789
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@khorshuheng: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…dev#779) Co-authored-by: Khor Shu Heng <khor.heng@gojek.com>
Which issue(s) this PR fixes:
The current publish helm chart script modifies the existing charts in the repository before publishing the chart. The original intention is that, should a developer forgot to update the version, the script will automatically correct the mistake.
However, this preprocessing is currently modifying the versions of the non-feast dependencies. As a result the helm chart publication job will fail due to dependency not being met (eg. Prometheus).
This PR remove the preprocessing step. Instead the developer should explicitly update the image/tag version in the release branch.
Does this PR introduce a user-facing change?: