Skip to content

Add API for listing feature sets using labels#785

Merged
feast-ci-bot merged 18 commits into
feast-dev:masterfrom
terryyylim:discovery-fs-api
Jun 17, 2020
Merged

Add API for listing feature sets using labels#785
feast-ci-bot merged 18 commits into
feast-dev:masterfrom
terryyylim:discovery-fs-api

Conversation

@terryyylim
Copy link
Copy Markdown
Member

@terryyylim terryyylim commented Jun 9, 2020

What this PR does / why we need it:
Adds listing functionality using labels for FeatureSet

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

User can now list feature sets by labels

@terryyylim terryyylim added the kind/feature New feature or request label Jun 9, 2020
@terryyylim
Copy link
Copy Markdown
Member Author

/test test-end-to-end-redis-cluster

@terryyylim
Copy link
Copy Markdown
Member Author

/test test-end-to-end

@terryyylim
Copy link
Copy Markdown
Member Author

/test test-end-to-end-batch

@terryyylim terryyylim changed the title [WIP] Discovery fs api Discovery fs api Jun 10, 2020
@terryyylim terryyylim changed the title Discovery fs api Add Discovery API for searching FeatureSets Jun 10, 2020
Comment thread core/src/main/java/feast/core/service/SpecService.java Outdated
Comment thread sdk/python/feast/cli.py Outdated
Comment thread sdk/python/feast/cli.py Outdated
Comment thread sdk/python/feast/cli.py Outdated
Comment thread sdk/python/feast/client.py Outdated
Comment thread tests/e2e/redis/basic-ingest-redis-serving.py Outdated
Comment thread tests/e2e/redis/basic-ingest-redis-serving.py Outdated
Comment thread core/src/main/java/feast/core/model/FeatureSet.java Outdated
Comment thread sdk/python/feast/cli.py
Comment thread core/src/main/java/feast/core/model/FeatureSet.java Outdated
Comment thread core/src/main/java/feast/core/model/FeatureSet.java Outdated
Comment thread core/src/main/java/feast/core/service/SpecService.java Outdated
Comment thread sdk/python/feast/cli.py Outdated
Comment thread sdk/python/feast/cli.py
@terryyylim
Copy link
Copy Markdown
Member Author

/test test-end-to-end-redis-cluster

@terryyylim terryyylim changed the title Add Discovery API for searching FeatureSets Add Discovery API for listing FeatureSets using labels Jun 13, 2020
@ches ches added this to the v0.6.0 milestone Jun 16, 2020
@woop woop changed the title Add Discovery API for listing FeatureSets using labels Add API for listing feature sets using labels Jun 17, 2020
@woop
Copy link
Copy Markdown
Member

woop commented Jun 17, 2020

/lgtm

@feast-ci-bot feast-ci-bot removed the lgtm label Jun 17, 2020
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terryyylim, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Copy Markdown
Member

woop commented Jun 17, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit a5bd877 into feast-dev:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants