Skip to content

Update helm installation docs - Fix broken link#808

Merged
woop merged 1 commit into
feast-dev:masterfrom
davidheryanto:update-helm-installation-readme-service-account
Jun 19, 2020
Merged

Update helm installation docs - Fix broken link#808
woop merged 1 commit into
feast-dev:masterfrom
davidheryanto:update-helm-installation-readme-service-account

Conversation

@davidheryanto
Copy link
Copy Markdown
Collaborator

@davidheryanto davidheryanto commented Jun 19, 2020

What this PR does / why we need it:
Fix broken hyperlink to the required roles for the service account in Feast in Helm installation docs.

Which issue(s) this PR fixes:

Fixes #802

Does this PR introduce a user-facing change?:

No

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto
Copy link
Copy Markdown
Collaborator Author

/retest

@woop woop merged commit fbb7a02 into feast-dev:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link to BigQuery permissions for service account is broken

3 participants