Replace Keto Authorization with External HTTP Authorization #864
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright 2018-2020 The Feast Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package feast.auth.authorization; | ||
|
|
||
| import feast.auth.generated.client.api.DefaultApi; | ||
| import feast.auth.generated.client.invoker.ApiClient; | ||
| import feast.auth.generated.client.invoker.ApiException; | ||
| import feast.auth.generated.client.model.CheckAccessRequest; | ||
| import java.util.Map; | ||
| import org.hibernate.validator.internal.constraintvalidators.bv.EmailValidator; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import org.springframework.security.core.Authentication; | ||
| import org.springframework.security.oauth2.jwt.Jwt; | ||
|
|
||
| /** | ||
| * HTTPAuthorizationProvider uses an external HTTP service for authorizing requests. Please see | ||
| * auth/src/main/resources/api.yaml for the API specification of this external service. | ||
| */ | ||
| public class HttpAuthorizationProvider implements AuthorizationProvider { | ||
|
|
||
| private static final Logger log = LoggerFactory.getLogger(HttpAuthorizationProvider.class); | ||
|
|
||
| private final DefaultApi defaultApiClient; | ||
|
|
||
| /** | ||
| * The default subject claim is the key within the Authentication object where the user's identity | ||
| * can be found | ||
| */ | ||
| private final String DEFAULT_SUBJECT_CLAIM = "email"; | ||
|
|
||
| /** | ||
| * Initializes the HTTPAuthorizationProvider | ||
| * | ||
| * @param options String K/V pair of options to initialize the provider with. Expects at least a | ||
| * "basePath" for the provider URL | ||
| */ | ||
| public HttpAuthorizationProvider(Map<String, String> options) { | ||
| if (options == null) { | ||
| throw new IllegalArgumentException( | ||
| "Cannot pass empty or null options to HTTPAuthorizationProvider"); | ||
| } | ||
|
|
||
| ApiClient apiClient = new ApiClient(); | ||
| apiClient.setBasePath(options.get("authorizationUrl")); | ||
| this.defaultApiClient = new DefaultApi(apiClient); | ||
| } | ||
|
|
||
| /** | ||
| * Validates whether a user has access to a project | ||
| * | ||
| * @param projectId Name of the Feast project | ||
| * @param authentication Spring Security Authentication object | ||
| * @return AuthorizationResult result of authorization query | ||
| */ | ||
| public AuthorizationResult checkAccessToProject(String projectId, Authentication authentication) { | ||
|
|
||
| CheckAccessRequest checkAccessRequest = new CheckAccessRequest(); | ||
| Object context = getContext(authentication); | ||
| String subject = getSubjectFromAuth(authentication, DEFAULT_SUBJECT_CLAIM); | ||
| checkAccessRequest.setAction("ALL"); | ||
| checkAccessRequest.setContext(context); | ||
| checkAccessRequest.setResource(projectId); | ||
|
Collaborator
There was a problem hiding this comment. we probably need to change this to include the resourcetype like
Member
Author
There was a problem hiding this comment. Oops, I fixed it but havent pushed yet.
Member
Author
There was a problem hiding this comment. I had the do-not-merge on for protection ;) But no worries, this at least allows your team to move ahead. I'll submit a patch tomorrow. I am going to bed now. |
||
| checkAccessRequest.setSubject(subject); | ||
|
|
||
| try { | ||
| // Make authorization request to external service | ||
| feast.auth.generated.client.model.AuthorizationResult authResult = | ||
| defaultApiClient.checkAccessPost(checkAccessRequest); | ||
| if (authResult == null) { | ||
| throw new RuntimeException( | ||
| String.format( | ||
| "Empty response returned for access to project %s for subject %s", | ||
| projectId, subject)); | ||
| } | ||
| if (authResult.getAllowed()) { | ||
| // Successfully authenticated | ||
| return AuthorizationResult.success(); | ||
| } | ||
| } catch (ApiException e) { | ||
| log.error("API exception has occurred during authorization: {}", e.getMessage(), e); | ||
| } | ||
|
|
||
| // Could not determine project membership, deny access. | ||
| return AuthorizationResult.failed( | ||
| String.format("Access denied to project %s for subject %s", projectId, subject)); | ||
| } | ||
|
|
||
| /** | ||
| * Extract a context object to send as metadata to the authorization service | ||
| * | ||
| * @param authentication Spring Security Authentication object | ||
| * @return Returns a context object that will be serialized and sent as metadata to the | ||
| * authorization service | ||
| */ | ||
| private Object getContext(Authentication authentication) { | ||
| // Not implemented yet, left empty | ||
| return new Object(); | ||
| } | ||
|
|
||
| /** | ||
| * Get user email from their authentication object. | ||
| * | ||
| * @param authentication Spring Security Authentication object, used to extract user details | ||
| * @param subjectClaim Indicates the claim where the subject can be found | ||
| * @return String user email | ||
| */ | ||
| private String getSubjectFromAuth(Authentication authentication, String subjectClaim) { | ||
| Jwt principle = ((Jwt) authentication.getPrincipal()); | ||
| Map<String, Object> claims = principle.getClaims(); | ||
| String subjectValue = (String) claims.get(subjectClaim); | ||
|
|
||
| if (subjectValue.isEmpty()) { | ||
| throw new IllegalStateException( | ||
| String.format("JWT does not have a valid claim %s.", subjectClaim)); | ||
| } | ||
|
|
||
| if (subjectClaim.equals("email")) { | ||
| boolean validEmail = (new EmailValidator()).isValid(subjectValue, null); | ||
| if (!validEmail) { | ||
| throw new IllegalStateException("JWT contains an invalid email address"); | ||
| } | ||
| } | ||
|
|
||
| return subjectValue; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.