Use maven project.build.outputDirectory not target/classes#40
Open
mobreza wants to merge 1 commit intofederkasten:masterfrom
Open
Use maven project.build.outputDirectory not target/classes#40mobreza wants to merge 1 commit intofederkasten:masterfrom
mobreza wants to merge 1 commit intofederkasten:masterfrom
Conversation
mobreza
force-pushed
the
10-maven-module-build
branch
from
33d28d8 to
623e840
Compare
Author
|
@federkasten Rebased on current master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reconfigures Velocity with
project.build.outputDirectorypath instead of usingTARGET_CLASS_ROOT. That allows the appbundler to run in maven subprojects.Fixes #10