Update MMM-GoogleCast.js and backend to use name insteads of id + actualization media_list correction#28
Open
gatienduboc wants to merge 5 commits intoferferga:masterfrom
Open
Update MMM-GoogleCast.js and backend to use name insteads of id + actualization media_list correction#28gatienduboc wants to merge 5 commits intoferferga:masterfrom
gatienduboc wants to merge 5 commits intoferferga:masterfrom
Conversation
Test with PyChromecast 13.0.8. Didn't know when the method used before was outdated
because Pychromecast seems doesn't work with uuid ???
…ualization of new medias
Little default of positionning of youtube-music text
apparently recent version of pychromecast doesn't find the chromecast if we use uuids
|
+1 Ran into the issue and this PR fixed it. Thanks! |
jamiesonpepper
approved these changes
Mar 16, 2025
jamiesonpepper
left a comment
jamiesonpepper
left a comment
There was a problem hiding this comment.
Can confirm similar to others noted that this PR works as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apparently recent version of pychromecast doesn't find the chromecast if we use uuids
Use pychromecast.get_listed_chromecasts(friendly_names=[deviceName]) instead of pychromecast.get_chromecasts()
Correction about the positionning of "app used" in the css file