update calls to aws.request to use new API (fixes #41)#42
Merged
fernando-mc merged 1 commit intofernando-mc:masterfrom Mar 12, 2018
Merged
update calls to aws.request to use new API (fixes #41)#42fernando-mc merged 1 commit intofernando-mc:masterfrom
fernando-mc merged 1 commit intofernando-mc:masterfrom
Conversation
Owner
|
@linusmarco I'd be super surprised if this doesn't break anything. Have you already tested it? |
Contributor
Author
|
@fernando-mc, yup I tested it and everything works. The way the updates Serverless API works, the region and stage are taken from Right now, we're passing Someone else should also test to make sure, though |
Owner
|
@linusmarco tested. This works. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
As described in #41, our calls to the AWS SDK
requestmethod use the old API, which has arguments for region and stage. The new API does not support these arguments, instead storing the region and stage elsewhere. Instead there is an optionaloptionsargument (which we don't need for anything in serverless-finch at the moment). Region and stage are set at initialization.Proposed changes
Change all calls to
aws.requestto remove the region and stage arguments. Example: