Distribute an ESM version #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for an improved experience with unbundled development tools like Vite and Snowpack. Those tools first have to convert all non-ESM dependencies to ESM. This allows those tools to operate more quickly.
Vite also will fail when an ESM module declares a dependency on a CJS module (vitejs/vite-plugin-react#30). This will allow
is-bufferto be used with SvelteKit / Vite projectsI just copied the file to avoid adding any type of build step since it's so small. But if you'd prefer, I could have just a single file with the other one being generated
Is the code comment supposed to be
/*!or/**? I left it as the former since that's what the existing file does, but it seems wrong to me