Skip to content

Conversation

@RemDelaporteMathurin
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Jun 17, 2025

Proposed changes

This is an attempt at fixing the nightly dolfinx CI by implementing the new SNES newton solver.

Based off the example available at here

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@RemDelaporteMathurin RemDelaporteMathurin changed the base branch from main to fenicsx June 17, 2025 20:35
@RemDelaporteMathurin RemDelaporteMathurin added enhancement New feature or request fenicsx Issue that is related to the fenicsx support labels Jun 17, 2025
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

❌ Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.27%. Comparing base (0a262f0) to head (7420028).
⚠️ Report is 176 commits behind head on fenicsx.

Files with missing lines Patch % Lines
src/festim/problem.py 93.18% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx    #1006      +/-   ##
===========================================
- Coverage    95.40%   95.27%   -0.14%     
===========================================
  Files           46       46              
  Lines         2851     2878      +27     
===========================================
+ Hits          2720     2742      +22     
- Misses         131      136       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RemDelaporteMathurin RemDelaporteMathurin marked this pull request as ready for review July 2, 2025 18:18
@RemDelaporteMathurin RemDelaporteMathurin mentioned this pull request Jul 15, 2025
10 tasks
@RemDelaporteMathurin RemDelaporteMathurin merged commit e10971d into fenicsx Jul 15, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fenicsx Issue that is related to the fenicsx support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants