Skip to content

Conversation

@KulaginVladimir
Copy link
Collaborator

Proposed changes

Thanks to @jorgensd, this PR should fix #983.

I tested the fix locally for the cases of parallel computation.

Let me know if the tests should be modified or there is a need to test the fix for mpirun via pytest-mpi.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@KulaginVladimir KulaginVladimir added the bug Something isn't working label Jul 4, 2025
@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.31%. Comparing base (2c06915) to head (9b411c6).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1010   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          60       60           
  Lines        2904     2921   +17     
=======================================
+ Hits         2884     2901   +17     
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KulaginVladimir for this fix! Just a couple of minor comments

@KulaginVladimir KulaginVladimir merged commit 0a19a7d into festim-dev:main Jul 14, 2025
6 checks passed
@KulaginVladimir KulaginVladimir deleted the surface_quantities_fix branch July 15, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] MaximumSurface requires surface_markers

2 participants