Skip to content

Conversation

@RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This is a quick fix following #685 I hadn't tested it for a single species case.
In HydrogenTransportProblem we have a MixedElement in multispecies but not otherwise. Which means functionspace.sub(..) won't work.

This is not a problem for the discontinuous case since we always create a mixed element, even with only one species.

@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.38%. Comparing base (db9ae13) to head (c984365).
⚠️ Report is 131 commits behind head on fenicsx.

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx    #1015   +/-   ##
========================================
  Coverage    95.37%   95.38%           
========================================
  Files           46       46           
  Lines         2920     2926    +6     
========================================
+ Hits          2785     2791    +6     
  Misses         135      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RemDelaporteMathurin RemDelaporteMathurin added bug Something isn't working fenicsx Issue that is related to the fenicsx support labels Jul 17, 2025
@RemDelaporteMathurin RemDelaporteMathurin merged commit c3ee455 into fenicsx Jul 17, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fenicsx Issue that is related to the fenicsx support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants