Skip to content

Conversation

@RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

Fix for #986

Caveat: this will not work if the temperature field (as a function!) needs to be updated. Ie: CoupledHeatTransferHydrogenTransportProblem.

I tried implementing the quadrature space interpolation as proposed by @jorgensd on the discourse channel. But this wasn't giving satisfactory results so I decided instead to interpolate on a function of the submesh instead. It works, this is the concentration field with c=2* T and T = 800 + 100x + y on the top surface:

image

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.73%. Comparing base (588429c) to head (4622e87).
⚠️ Report is 127 commits behind head on fenicsx.

Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx     #987      +/-   ##
===========================================
+ Coverage    95.71%   95.73%   +0.02%     
===========================================
  Files           46       46              
  Lines         2751     2764      +13     
===========================================
+ Hits          2633     2646      +13     
  Misses         118      118              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhdark jhdark merged commit d3d881c into fenicsx Apr 29, 2025
12 of 14 checks passed
@jhdark jhdark deleted the fix-temperature-parent-mesh branch April 29, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants